Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support DestSurveyID parameter to RPC method copy_survey #1016

Merged
merged 1 commit into from
Oct 29, 2023
Merged

feat: Support DestSurveyID parameter to RPC method copy_survey #1016

merged 1 commit into from
Oct 29, 2023

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Oct 29, 2023 •
edited by github-actions bot
Loading

@edgarrmondragon edgarrmondragon added enhancement New feature or request RPC Issues related to the RPC client implementation labels Oct 29, 2023
@trunk-io
Copy link

trunk-io bot commented Oct 29, 2023

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@edgarrmondragon edgarrmondragon force-pushed the feat/copy-survey-destination_survey_id branch 2 times, most recently from b167d1e to 6a137e6 Compare October 29, 2023 02:56
@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4447345) to head (984c6bc).
Report is 151 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1016   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          422       434   +12     
  Branches        22        23    +1     
=========================================
+ Hits           422       434   +12
Flag Coverage Δ
integration 90.55% <100.00%> (+0.26%) ⬆️
unit 93.08% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the feat/copy-survey-destination_survey_id branch from 6a137e6 to 00de1cd Compare October 29, 2023 03:08
@edgarrmondragon edgarrmondragon added the Release Package version bump label Oct 29, 2023
@edgarrmondragon edgarrmondragon force-pushed the feat/copy-survey-destination_survey_id branch 6 times, most recently from ad90095 to 30485b7 Compare October 29, 2023 04:15
@edgarrmondragon edgarrmondragon force-pushed the feat/copy-survey-destination_survey_id branch from 30485b7 to 984c6bc Compare October 29, 2023 04:49
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 29, 2023 04:58
@edgarrmondragon edgarrmondragon merged commit 10a79be into main Oct 29, 2023
57 checks passed
@edgarrmondragon edgarrmondragon deleted the feat/copy-survey-destination_survey_id branch October 29, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request Release Package version bump RPC Issues related to the RPC client implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edgarrmondragon